April 20, 2026
4:16 p.m.
On Fri Apr 17 19:58:07 2026 +0000, Jan Robert Gerigk wrote:
I have addressed all three points: 2/7 and 3/7: removed the scope blocks, moved parent_id\[\] (and friends in 3/7: parent_sp, child_ids, count) to the functions declaration block. 7/7: replaced the non-empty check with ok(!wcscmp(buffer_w, L"ROOT\\WINETEST\\0"), ...) plus a matching size check. As a side effect, 4/7s scope block and duplicate child_ids/count are gone. The Siblings loop now reuses the function-level vars from 3/7, with a single free() at the end. And tests for 1/7, 3/7, and 4/7?
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10604#note_137123