Re: [PATCH 0/3] MR11248: winewayland: Use xdg-popup instead of subsurfaces for owned or equivalent windows.

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/winewayland.drv/wayland_surface.c:
> +    if ((surface = data->wayland_surface) && wayland_surface_is_popup(surface))
> +    {
> +        SetRect(&surface->pending.rect, x, y, x + width, y + height);
> +        surface->pending.state = 0;
> +    }
> +
> +    wayland_win_data_release(data);
> +}
> +
> +static void xdg_popup_handle_done(void *private, struct xdg_popup *xdg_popup)
> +{
> +    struct wayland_surface *surface;
> +    struct wayland_win_data *data;
> +    HWND hwnd = private;
> +
> +    if (!xdg_popup) return;
> I wasn't sure if this was even needed, I kept it just in case but IMO we should not add ifs unless really necessary.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/11248#note_144079