Re: [PATCH v5 0/5] MR10550: winex11: Keyboard layouts rework, part 1

[Rémi Bernon (＠rbernon)]

On Fri Apr 17 17:50:13 2026 +0000, Matteo Bruni wrote:
> Or, actually, the other way around, making `SONAME_LIBXKBREGISTRY` only
> be defined if the header is present.
> ```
> if test "x$have_x$with_wayland" != "xnono"
> then
>     WINE_PACKAGE_FLAGS(XKBREGISTRY,[xkbregistry],,,,
>         [AC_CHECK_HEADER([xkbcommon/xkbregistry.h],
>                 [WINE_CHECK_SONAME(xkbregistry,rxkb_context_new,[:],[XKBREGISTRY_LIBS=""],[$XKBREGISTRY_LIBS])])])
> fi
> ```
> Does that look alright to you?
> `AC_CHECK_HEADER` doesn't define the HAVE_XKBCOMMON_XKBREGISTRY_H macro, you need `AC_CHECK_HEADERS` and it doesn't let you do things on success / failure, you'd have to manually write a test.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10550#note_136808