Re: [PATCH 0/1] MR11071: ntdll: Ignore hardware breakpoint traps inside the signal stack.

[Paul Gofman (＠gofman)]

Paul Gofman (@gofman) commented about dlls/ntdll/unix/signal_x86_64.c:
> R10_sig( sigcontext ) = RCX_sig( sigcontext );
>          fixup_frame_fpu_state( frame, sigcontext );
>      }
> -    else if (siginfo->si_code == 4 /* TRAP_HWBKPT */ && is_inside_syscall( data, RSP_sig(sigcontext) ))
> +    else if (siginfo->si_code == 4 /* TRAP_HWBKPT */ &&
> +             (is_inside_syscall( data, RSP_sig(sigcontext) ) ||
> +              is_inside_signal_stack( data, (void *)RSP_sig(sigcontext) )))
>      {
> -        TRACE_(seh)( "ignoring HWBKPT in syscall rip=%p\n", (void *)RIP_sig(sigcontext) );
> +        TRACE_(seh)( "ignoring HWBKPT in syscall/signal stack rip=%p\n",
> +                     (void *)RIP_sig(sigcontext) );

```suggestion
    else if (siginfo->si_code == 4 /* TRAP_HWBKPT */ && (is_inside_syscall( data, RSP_sig(sigcontext) )
             || is_inside_signal_stack( data, (void *)RSP_sig(sigcontext) )))
    {
        TRACE_(seh)( "ignoring HWBKPT rip=%p\n", (void *)RIP_sig(sigcontext) );
        return TRUE;
    }
```

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/11071#note_142240