April 28, 2026
12:28 p.m.
On Tue Apr 28 12:28:43 2026 +0000, Jon Koops wrote:
Thanks for the review @Mystral, I'll see if I can incorporate the feedback. As for the style of the tests, what would you like it to look like? I used the existing tests for dsound as a reference to implement the new ones added here. My preference would be for something like my suggested changes, or the test immediately above yours. To be clear, there's nothing wrong on your part: I'm just a bit annoyed that there's so much old code around that makes for bad style examples :sweat_smile:
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10735#note_137977