[PATCH v2 2/7] msxml3: Fix a leak when parsing xml declaration body (Coverity).

[Nikolay Sivov]

From: Nikolay Sivov <[e-mail]>

Signed-off-by: Nikolay Sivov <[e-mail]>
---
 dlls/msxml3/saxreader.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/dlls/msxml3/saxreader.c b/dlls/msxml3/saxreader.c
index 4b0ec0085d7..a4aa5728409 100644
--- a/dlls/msxml3/saxreader.c
+++ b/dlls/msxml3/saxreader.c
@@ -6477,12 +6477,14 @@ static void saxreader_parse_xmldecl_body(struct saxlocator *locator)
         else
         {
             saxreader_set_error(locator, E_SAX_UNEXPECTED_ATTRIBUTE);
-            continue;
         }
 
         saxreader_free_name(&name);
         SysFreeString(value);
 
+        if (locator->status != S_OK)
+            continue;
+
         saxreader_skipspaces(locator);
         if (locator->eos)
             return;
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/10706