On Mon Aug 24 14:24:38 2026 +0000, Jinoh Kang wrote:
Does this actually work? Our tests are non-interactive, and should never leave stray windows open when the test finishes. It works under WINE, because WINE launches a separate `explorer` process for every folder window, and therefore gives a process handle. Without this bit, the WINE session never ends, which is very annoying.
However, I would not be surprised if it does nothing on Windows (which doesn't launch separate `explorer` processes) and there is in fact a hidden explorer window sticking around, which is not good… I think it might be possible to rework this to try to find the new window with `IShellWindows` and close it, but that would make things very complicated and I'm a little worried it might be fragile. If I removed the test, do you think the fix would still be mergeable? Otherwise, I guess I'll do the `IShellWindows` thing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/11709#note_149683