Re: [PATCH 0/1] MR10471: unwind: fix some invalid `reinterpret_cast`s

[Alfred Agrell (＠Alcaro)]

Alfred Agrell (@Alcaro) commented about libs/unwind/include/libunwind.h:
> typedef struct unw_context_t unw_context_t;
>
> struct unw_cursor_t {
> -  uint64_t data[_LIBUNWIND_CURSOR_SIZE];
> +    /* Only the “array of N unsigned char” or of type “array of N std::byte” types can used as
> +    storage (https://eel.is/c++draft/intro.object#3) */
> +  union {
> +    unsigned char data[_LIBUNWIND_CURSOR_SIZE * sizeof(uint64_t)];
> +    /* `aligner` exists only for alignment */
> Wouldn't alignas make more sense? Or are we trying to avoid c++11 features?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10471#note_134023