Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/treeview.c:
expect(TRUE, r); AddItem('.'); ok(!strcmp(sequence, "1(nR)nR23(Rn)Rn45(nR)nR."), "root-none select test\n"); - ok_sequence(sequences, TREEVIEW_SEQ_INDEX, rootnone_select_seq, - "root-none select seq", FALSE); + ok_sequence(sequences, TREEVIEW_SEQ_INDEX, rootnone_select_seq, "root-none select seq", FALSE);
I don't like that the TVN_ITEMCHANGING and TVN_ITEMCHANGED message tests are mixing with other tests. Please separate them into a new test function. For example, if selecting or setting one item triggers TVN_ITEMCHANGING and TVN_ITEMCHANGED, then you test specifically that, not adding the tests where there are multiple unnecessary child items. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10451#note_137907