Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/tests/mesh.c:
- todo_wine ok(!face_index, "Got unexpected face index %lu.\n", face_index); - todo_wine ok(compare(u, 0.25f), "Got unexpected u %.8e.\n", u); - todo_wine ok(compare(v, 0.25f), "Got unexpected v %.8e.\n", v); - todo_wine ok(compare(dist, 1.0f), "Got unexpected distance %.8e.\n", dist); - todo_wine ok(count == 2, "Got unexpected hit count %lu.\n", count); - todo_wine ok(!!all_hits, "Expected a hit buffer.\n"); + ok(hr == D3D_OK, "Got unexpected hr %#lx.\n", hr); + ok(hit, "Expected a hit.\n"); + ok(!face_index, "Got unexpected face index %lu.\n", face_index); + ok(compare(u, 0.25f), "Got unexpected u %.8e.\n", u); + ok(compare(v, 0.25f), "Got unexpected v %.8e.\n", v); + ok(compare(dist, 1.0f), "Got unexpected distance %.8e.\n", dist); + ok(count == 2, "Got unexpected hit count %lu.\n", count); + ok(!!all_hits, "Expected a hit buffer.\n"); if (all_hits) { The `if` should be dropped as well, since at this point there is no expectation of ever getting `!all_hits` anymore.
Same for the other similar cases below. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/11482#note_147829