From: Andrey Gusev <andrey.goosev@gmail.com> --- dlls/dsound/capture.c | 4 +++- dlls/dsound/dsound.c | 4 +++- dlls/dsound/duplex.c | 4 +++- dlls/dsound/propset.c | 4 +++- 4 files changed, 12 insertions(+), 4 deletions(-) diff --git a/dlls/dsound/capture.c b/dlls/dsound/capture.c index dfb5e7d921c..b29c0bd9f48 100644 --- a/dlls/dsound/capture.c +++ b/dlls/dsound/capture.c @@ -1297,7 +1297,9 @@ HRESULT IDirectSoundCaptureImpl_Create(IUnknown *outer_unk, REFIID riid, void ** obj->outer_unk = &obj->IUnknown_inner; hr = IUnknown_QueryInterface(&obj->IUnknown_inner, riid, ppv); - IUnknown_Release(&obj->IUnknown_inner); + + if (FAILED(hr)) + IUnknown_Release(&obj->IUnknown_inner); return hr; } diff --git a/dlls/dsound/dsound.c b/dlls/dsound/dsound.c index c21090d95e2..f85294e84db 100644 --- a/dlls/dsound/dsound.c +++ b/dlls/dsound/dsound.c @@ -963,7 +963,9 @@ HRESULT IDirectSoundImpl_Create(IUnknown *outer_unk, REFIID riid, void **ppv, BO obj->outer_unk = &obj->IUnknown_inner; hr = IUnknown_QueryInterface(&obj->IUnknown_inner, riid, ppv); - IUnknown_Release(&obj->IUnknown_inner); + + if (FAILED(hr)) + IUnknown_Release(&obj->IUnknown_inner); return hr; } diff --git a/dlls/dsound/duplex.c b/dlls/dsound/duplex.c index a9fef428b28..d5e1a0f3840 100644 --- a/dlls/dsound/duplex.c +++ b/dlls/dsound/duplex.c @@ -296,7 +296,9 @@ HRESULT DSOUND_FullDuplexCreate(REFIID riid, void **ppv) obj->numIfaces = 1; hr = IUnknown_QueryInterface(&obj->IUnknown_iface, riid, ppv); - IUnknown_Release(&obj->IUnknown_iface); + + if (FAILED(hr)) + IUnknown_Release(&obj->IUnknown_iface); return hr; } diff --git a/dlls/dsound/propset.c b/dlls/dsound/propset.c index 7e079599ca7..711029adfe0 100644 --- a/dlls/dsound/propset.c +++ b/dlls/dsound/propset.c @@ -642,7 +642,9 @@ HRESULT IKsPrivatePropertySetImpl_Create(REFIID riid, void **ppv) iks->IKsPropertySet_iface.lpVtbl = &ikspvt; hr = IKsPropertySet_QueryInterface(&iks->IKsPropertySet_iface, riid, ppv); - IKsPropertySet_Release(&iks->IKsPropertySet_iface); + + if (FAILED(hr)) + IKsPropertySet_Release(&iks->IKsPropertySet_iface); return hr; } -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/10602