Re: [PATCH v4 0/3] MR10743: small odbc fixes

[Hans Leidekker (＠hans)]

Hans Leidekker (@hans) commented about dlls/odbc32/unixlib.c:
> WCHAR buffer[1024], *filename = get_driver_filename( desc );
>          KEY_VALUE_PARTIAL_INFORMATION *info = (KEY_VALUE_PARTIAL_INFORMATION *)buffer;
>
> +        if (!filename) WARN("%s: driver not registered, skipping Driver path write\n", debugstr_w(dsn));
> +
>          dir = SQL_FETCH_NEXT;
>          if (!query_value( key_sources, dsn, len_dsn * sizeof(WCHAR), info, sizeof(buffer) ) && desc[0])
>          {

I don't think this warrants a warning message. You should continue right away, otherwise we'd create a data source for which no driver is available.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10743#note_137754