Re: [PATCH v4 0/1] MR10505: vbscript: Implement Filter function.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/vbscript/global.c:
> +            hres = to_string(&data[i - lbound], &conv_str);
> +            if(FAILED(hres)) {
> +                SafeArrayUnaccessData(sa);
> +                goto done;
> +            }
> +            str = conv_str;
> +        }
> +
> +        if(!SysStringLen(search))
> +            found = 1;
> +        else
> +            found = FindStringOrdinal(FIND_FROMSTART, str, SysStringLen(str),
> +                                      search, SysStringLen(search), mode) >= 0;
> +
> +        if(conv_str)
> +            SysFreeString(conv_str);
> It's fine to pass NULL to `SysFreeString`, so this check is not needed (same in other cases).

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10505#note_135528