July 31, 2026
5:14 p.m.
On Fri Jul 31 17:14:44 2026 +0000, Attila Fidan wrote:
I realized the browse_info's pidlRoot is accessed later in BrsFolder_OnSetExpanded when BFFM_SETEXPANDED/BFFM_SETSELECTIONA/W is sent, but when I re-used test_selection's selection_callback and selected_folder_pidl variable, native also crashes with access violation on the tests with FALSE wparam and non-zero lparams. The affected applications don't send these messages. Unless it's possible to modify original pidl later in callbacks, we should simply store a clone and not access original pointer.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8861#note_147495