April 6, 2026
6:50 p.m.
1/8 has a whitespace error. 3/8: ``` +#define FOURCC_IYUV mmioFOURCC('I', 'Y', 'U', 'V') +#define IYUV_MAGIC FOURCC_IYUV ``` Why do you need both of those macros? ``` + LoadStringW(IYUV_32_module, IDS_NAME, icinfo->szName, ARRAY_SIZE(icinfo->szName)); + LoadStringW(IYUV_32_module, IDS_DESCRIPTION, icinfo->szDescription, ARRAY_SIZE(icinfo->szDescription)); ``` I suppose the other drivers do this too, but I'm not convinced it's useful. 7/8: ``` + stride = -((out->biWidth * depth + 3) & ~3); ``` That should depend on the sign of the height. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10549#note_135160