Re: [PATCH v2 0/3] MR10571: ntdll: Add NtCreateWaitablePort stub

[Alfred Agrell (＠Alcaro)]

Alfred Agrell (@Alcaro) commented about dlls/ntdll/tests/port.c:
> else ok(status == STATUS_SUCCESS, "Expected STATUS_SUCCESS, got %ld\n", status);
>
> +    if (status == STATUS_SUCCESS)
> +    {
> +        DWORD id;
> +        HANDLE thread = CreateThread(NULL, 0, test_ports_client, NULL, 0, &id);
> +        ok(thread != NULL, "Expected non-NULL thread handle!\n");
> +
> +        test_ports_server( port_handle );
> +        ok( WaitForSingleObject( thread, 10000 ) == 0, "thread didn't exit\n" );
> +        CloseHandle(thread);
> +    }
> +
> +    status = pNtCreateWaitablePort(&port_handle, &obj, 100, 100, 0);
> +    if (status == STATUS_ACCESS_DENIED) skip("Not enough rights\n");
> +    else ok(status == STATUS_SUCCESS, "Expected STATUS_SUCCESS, got %ld\n", status);

ew, ntstatus in base 10.

I won't fault you for copying ugly code, but feel free to replace with %08lx.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10571#note_135102