April 13, 2026
8:24 a.m.
On Mon Apr 13 08:24:25 2026 +0000, Akihiro Sagawa wrote:
I'm a bit concerned about allocating 32KB on the stack, as that's quite large. Since adding proper length validation would make this patch more complex, I understand why you avoided it here. Would you leave the buffer size unchanged in this patch and create a follow-up patch that allocates the 32KB temporary buffer on the heap instead? That way we can avoid the stack usage issue without expanding the scope of this merge request. Noted. I have reverted it. I will push a follow up patch the way you mentioned
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10192#note_135935