On Fri Jun 19 07:52:18 2026 +0000, Rémi Bernon wrote:
Can both even be added at the same time, what is it supposed to do? I think we can just keep the error message and use the same check in VK_STRUCTURE_TYPE_D3D12_FENCE_SUBMIT_INFO_KHR. From the spec: "If the semaphore in VkSubmitInfo::pWaitSemaphores or VkSubmitInfo::pSignalSemaphores corresponding to an entry in pWaitSemaphoreValues or pSignalSemaphoreValues respectively does not currently have a payload referring to a Direct3D 12 fence, the implementation must ignore the value in the pWaitSemaphoreValues or pSignalSemaphoreValues entry." (https://docs.vulkan.org/refpages/latest/refpages/source/VkD3D12FenceSubmitIn...).
So my understanding is that if you want to mix timelines sems with d3d12 fences in the same submit wait or signal array you should provide both fence and timeline submit info and for each semaphore implementation should use the value from the corresponding structure type. Not sure why, maybe that is because those are different extensions. Besides, structures have important difference: waitSemaphoreValuesCount in d3d12 vs waitSemaphoreValueCount in timeline submit info. That said, this dance with ERR vs FIXMES looks clumsy, indeed looks better probably to just have the same ERR there, the needed log hint is apparent anyway, I will change that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/11175#note_143633