On Fri Jun 26 16:05:47 2026 +0000, Elizabeth Figura wrote:
This is hard to read and could probably do with quite a lot of splitting. In particular: * D3D11_FORMAT_SUPPORT_BACK_BUFFER_CAST implementation can be its own commit It also should not use a fixed list of formats, and should live in wined3d like all the other format flags. * D3D11_FORMAT_SUPPORT_BACK_BUFFER_CAST validation similarly can be its own commit, and also should live in wined3d. Actually, you seem to unnecessarily have it in both places? * Tracking the list of swapchain views, while not doing anything with them yet, can be its own commit. * GL and Vulkan rotate implementations should ideally be separated. * Disabling GL_FRAMEBUFFER_SRGB on swapchain blit is still wrong, as Henri said. (Moving it back "to fix test failures" is not correct; you need to understand why it *should* be there.) And that should be its own commit; it's not related to the rest of this. * Diffs like this should just be avoided entirely: ``` - unsigned int swap_interval; - unsigned int max_frame_latency; + unsigned int swap_interval, max_frame_latency; ``` * I would not use the fixed array size of 29; just allocate it dynamically instead the same as we do for the actual list of backbuffers. With that done, wined3d_swapchain_rendertarget_view_gl is fairly unnecessary; it's just a single pointer that can be put directly in wined3d_rendertarget_view like the others. Thanks for review. I'll split as multiple commits so its easier to digest and include the other changes as you recommended.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10567#note_144323