On Mon May 18 07:51:10 2026 +0000, Twaik Yont wrote:
Right, ntlm_auth is external to Wine. However, this patch is not trying to special-case Android or decide whether ntlm_auth should be supported there. It only adds a fallback for systems where posix_spawn() is not available. Even if Android is currently the only such target in practice, disabling ntlm_auth there would be a separate change and could accidentally break setups that provide a Samba ntlm_auth-compatible helper. It would also mask the posix_spawn() portability issue rather than fixing it. I'd prefer to keep the existing ntlm_auth behavior unchanged and only make the helper startup path work without posix_spawn(). In the case of ntlm_auth I don't think the extra complexity is worth the trouble.
TBH I'm not convinced that even in ntdll we have to go out of our way to support old Android versions. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10926#note_140330