March 26, 2026
1:44 a.m.
Anton Baskanov (@baskanov) commented about dlls/dsound/mixer.c:
for (j = 0; j < fir_width; j++) sum += (fir[idx + j] * rem_inv + fir[idx + j + fir_width] * rem) * cache[j]; output[i] = sum; + + rem_inv += rem_inv_step; + rem_inv -= rem_inv > 1.0f ? 1.0f : 0.0f;
This is incorrect, `rem_inv` should never be equal to `1.0`, so `>=` should be used instead of `>`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10423#note_133816