On Sun May 3 21:07:27 2026 +0000, Piotr Pawłowski wrote:
Moved new tests specifically testing TVN_ITEMCHANGING functionality to a new function. The rest should be good as it is? I added parent message sequences to various existing tests instead of inventing new, I don't think there's any point in duplicating them with/without parent message sequences? The tests for TVN_ITEMCHANGING and TVN_ITEMCHANGED are still mixed with other tests. So you have things like parent_rootnone_select_seq_v6 that include multiple pairs of TVN_ITEMCHANGING and TVN_ITEMCHANGED. The ideal way is to test TVN_ITEMCHANGING and TVN_ITEMCHANGED specifically. For example, when there is only one child item, there will be only **one pair** of TVN_ITEMCHANGING and TVN_ITEMCHANGED. This way, the tests would be much cleaner and clearly separated from existing tests.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10451#note_139401