Re: [PATCH 0/6] MR10963: winex11: Keyboard layouts rework, part 3

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/winex11.drv/keyboard.c:
> +
>      return TRUE;
>  }
>
> +static void x11drv_update_input_lang( Display *display )
> +{
> +    unsigned old_kbd_layout = kbd_layout;
> +    HWND hwnd;
> +    HKL hkl;
> +
> +    init_keyboard_layouts( display );
> +    if (kbd_layout != old_kbd_layout)
> +    {
> +        hwnd = get_focus();
> +        if (!hwnd) hwnd = get_active_window();
> +        hkl = get_hkl( main_key_tab[kbd_layout].lcid, 0 );
> This seem to rely on the fuzzy layout detection which I believe is still not accurate. I don't think we should build up more features on top of it, so I would say this looks premature?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10963#note_140941