April 14, 2026
2:13 p.m.
On Sun Apr 12 10:28:05 2026 +0000, Zhiyi Zhang wrote:
Could you make these tests simpler? For example, I would expect that after getting an item to change, there is a sequence of TVN_ITEMCHANGING and TVN_ITEMCHANGED. Having a long sequence of messages after many operations is not exactly easy to understand. Keep the test as simple as possible. Original parent_rootchild_select_seq test wasn't by me, I only added correct v6 sequence to it.
I've been trying to avoid changing what's not relevant to specific fix being made. Do you want me to split this into multiple sequences per each TVM_SELECTITEM? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10451#note_136088