April 8, 2026
10:41 a.m.
On Wed Apr 8 10:41:11 2026 +0000, Zhiyi Zhang wrote:
Let's compare `generation` separately and only use memcmp() for `indices`. Changing `generation` to `unsigned long` works, but someday someone might add a new field and the comparison will break silently again. It's never going to be fully future proof, adding new fields we might also forget to add them to the comparison. Other state structures use memcmp directly, and I think it is better to use a common pattern. We'll just need to be mindful of alignment, which could be indicated with a comment.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10598#note_135474