Why test ReceiveConnection() on only these subtypes? If the others return VFW_E_TYPE_NOT_ACCEPTED, we should validate that in the test and then skip the rest of the new tests.
OK, fair point. I've changed that.
This would be more convincing if you also test a height of 1 is accepted. There's other reasons for -1 to be potentially invalid: it doesn't match the height returned from EnumMediaTypes(); it's not aligned; it doesn't match biSizeImage or lSampleSize.
Again, fair call. And again I've changed that.
Are we sure only setting the subtype is enough? Probably everything else needs to match, too.
It seems to be. The tests already test different heights and widths and they pass.
This could use a GetFormat() test.
I've added one, but it just returns `MS_E_NOSTREAM`.
The name ddraw_validate_format() seems odd
OK, yeah you're right. I've changed it to `ddrawstream_check_pixel_format`.
I don't think we need to bother checking if the format we get from GetDisplayMode() has DDSD_PIXELFORMAT set.
OK, I wasn't sure myself so I included it just in case. Now removed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10643#note_136024