From: Nikolay Sivov <nsivov@codeweavers.com> Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com> --- dlls/msxml3/notation.c | 8 ++++---- dlls/msxml3/tests/domdoc.c | 10 ++++++++++ 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/dlls/msxml3/notation.c b/dlls/msxml3/notation.c index e2a6eb13f1a..4210401f1b0 100644 --- a/dlls/msxml3/notation.c +++ b/dlls/msxml3/notation.c @@ -290,16 +290,16 @@ static HRESULT WINAPI domnotation_get_nodeTypeString(IXMLDOMNotation *iface, BST static HRESULT WINAPI domnotation_get_text(IXMLDOMNotation *iface, BSTR *p) { - FIXME("%p, %p: stub\n", iface, p); + TRACE("%p, %p.\n", iface, p); - return E_NOTIMPL; + return return_bstr(L"", p); } static HRESULT WINAPI domnotation_put_text(IXMLDOMNotation *iface, BSTR p) { - FIXME("%p, %s: stub\n", iface, debugstr_w(p)); + TRACE("%p, %s.\n", iface, debugstr_w(p)); - return E_NOTIMPL; + return E_FAIL; } static HRESULT WINAPI domnotation_get_specified(IXMLDOMNotation *iface, VARIANT_BOOL *v) diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c index 63706fb5ac0..7df00f0a2a2 100644 --- a/dlls/msxml3/tests/domdoc.c +++ b/dlls/msxml3/tests/domdoc.c @@ -17859,6 +17859,16 @@ static void test_dtd_children(void) ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); ok(!wcscmp(str, L"notation"), "Unexpected type %s.\n", debugstr_w(str)); SysFreeString(str); + hr = IXMLDOMNode_get_text(node, NULL); + ok(hr == E_INVALIDARG, "Unexpected hr %#lx.\n", hr); + hr = IXMLDOMNode_get_text(node, &str); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + ok(!*str, "Unexpected text %s.\n", debugstr_w(str)); + SysFreeString(str); + hr = IXMLDOMNode_put_text(node, NULL); + ok(hr == E_FAIL, "Unexpected hr %#lx.\n", hr); + hr = IXMLDOMNode_put_text(node, _bstr_("text")); + ok(hr == E_FAIL, "Unexpected hr %#lx.\n", hr); expect_node(node, "N1.DT2.D1"); hr = IXMLDOMDocumentType_removeChild(doctype, node, &node2); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/11409