On Wed Apr 8 19:57:21 2026 +0000, Tim Clem wrote:
Well.. we definitely want the constants in the header to match Windows... Honestly maybe it's just not worth worrying about the length check. It's a very unlikely scenario that it would matter anyway; it's not like that string is going to be dynamically generated. Sorry this turned out to be so complicated; I assumed it'd just be a simple check. I will keep the length check at \> 128 since it matches the CI results. Pushing the update now with a new code quality fix too.
And thanks for your patience and Feedback, I only started looking into Wine a few months ago as part of a project to get KNX ETS (a building automation software) running on Linux, and I have only been contributing upstream for a few weeks now. My understanding of Wines internals is still very surface-level, so I really appreciate the feedback. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10565#note_135556