Matteo Bruni (@Mystral) commented about dlls/winex11.drv/keyboard.c:
int vkey_range;
pthread_mutex_lock( &kbd_mutex ); - XDisplayKeycodes(display, &min_keycode, &max_keycode); + XDisplayKeycodes( display, &min_keycode, &max_keycode ); XFree( XGetKeyboardMapping( display, min_keycode, max_keycode + 1 - min_keycode, &keysyms_per_keycode ) );
- mmp = XGetModifierMapping(display); + mmp = XGetModifierMapping( display ); kcp = mmp->modifiermap; - for (i = 0; i < 8; i += 1) /* There are 8 modifier keys */ + for (int i = 0; i < 8; i += 1) /* There are 8 modifier keys */
This (until the next patch) shadows the other `i` declaration above, which seems unintended. At some point (relatively soon) I'm going to have another loop in the same function which could use the same `i`, but doesn't have to. Do you prefer if I get rid of the earlier declaration at the top of the function or that I revert this one change? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10689#note_136775