On Mon Apr 6 16:19:29 2026 +0000, Nikolai Abdusamatov wrote:
Thanks for the review. This patch ecae98b8c11f56042794290e83ffae30ef98de2a doesn't filter out loopback, WireGuard, or other pseudo adapters - it only reorders the list so physical Ethernet and Wi-Fi adapters with a valid MAC come first. On macOS, the current backend order follows the system `if_index`, so tunnel interfaces like `gif0` and `stf0` can appear before physical adapters. The change here is to normalize the order so physical adapters are placed first, which matches the order I observed on Windows. I also investigated the Aion 4.8 case. The client calls `GetAdaptersInfo` with a fixed buffer of 11264 bytes. On a system with 25 interfaces, the API returns `ERROR_BUFFER_OVERFLOW` and reports that 17088 bytes are needed. The client does not retry, so it never gets a valid adapter list and falls back to an empty MAC string. That is why the server sees an empty MAC. The issue here is that the app never receives a usable adapter list on this path. The sorting change helps apps that take the first adapter from `GetAdaptersInfo`, but it does not change the fixed-buffer overflow behavior in Aion. I'll also attach the logs from before and after these changes. [ndis_clean.txt](/uploads/6a96683e4b2e68ef9f9014df42d9ad55/ndis_clean.txt) [ndis_changes.txt](/uploads/94ecfe0943169b81ea0f8dd8015cde4d/ndis_changes.txt) This needs checks on Windows. I did one, enabling Proton VPN. I am attaching the patch which adds a bit more of info to GetAdaptersInfo test output and the output from up to date Windows 11.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10553#note_135129