Re: [PATCH v10 0/5] MR9992: Introduce ImeToAsciiEx() user driver function for use in winemac

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/winemac.drv/keyboard.c:
> TRACE("himc %p, vkey %#x state %p repeat %u\n",
>            himc, vkey, state, repeat);
>
> -    if (!state) return 0;
> +    if (!state) return STATUS_SUCCESS;
> +
> +    if (!macdrv_using_input_method()) return STATUS_NOT_IMPLEMENTED;
> +
> +    if (vsc & KF_UP)
> +    {
> +        /* Only key down events should be sent to the Cocoa input context. We do
> +           not handle key ups, and instead let those go through as a normal
> +           WM_KEYUP. */
> +        return STATUS_NOT_IMPLEMENTED;
> +    }

What about filtering these directly in ImeProcessKey? I don't think any host IME needs key up events.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9992#note_136080