Rémi Bernon (@rbernon) commented about dlls/winex11.drv/keyboard.c:
return MAKELANGID(LANG_NEUTRAL, SUBLANG_CUSTOM_UNSPECIFIED); };
+#endif + +static BOOL init_xkb_layouts( Display *display, XkbDescRec *xkb_desc, unsigned int xkb_group ) +{ +#ifdef SONAME_LIBXKBREGISTRY + unsigned int count; + char *names[4];
I still don't think this should be conditionally compiled. There could be other ways to lookup xkb layouts than the xkbregistry library, and that's something that is already isolated in the `find_xkb_layout_variant` function, which could be extended. The conditional compilation only adds more complexity and requires more ifdefs in the next patch. And without the need for more ifdefs, this commit also doesn't seem to be worth doing, especially as we just introduced this block of code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10779#note_139405