Re: [PATCH 0/5] MR10779: winex11: Keyboard layouts rework, part 2

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/winex11.drv/keyboard.c:
> return MAKELANGID(LANG_NEUTRAL, SUBLANG_CUSTOM_UNSPECIFIED);
>  };
>
> +#endif
> +
> +static BOOL init_xkb_layouts( Display *display, XkbDescRec *xkb_desc, unsigned int xkb_group )

Please lets avoid moving and renaming things that were just introduced in the previous batch. Also this only adds more code under conditional compilation and I think we should try moving the other way.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10779#note_138308