On Thu Apr 30 12:32:50 2026 +0000, Hendrik Borchardt wrote:
Sure, will do. But maybe this needs to be changed in the wiki? https://gitlab.winehq.org/wine/wine/-/wikis/Submitting-Patches#patch-guideli...: "If you've written a fix and a lot of new [conformance tests](Conformance-Tests) for an issue, add the tests as a separate commit ~~before~~after the fix" You can introduce the test before implementing the fix. Failing tests needs to be marked with `todo_wine`. Then, in the commit that adds the missing functionality, remove the `todo_wine` markers from those tests.
This change is easy to understand/review. In such case I don't mind if the tests are introduced first. The tests need to pass after every commit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10785#note_138376