On Tue Apr 21 18:20:33 2026 +0000, Rémi Bernon wrote:
Won't this fail to find a new device unless EnumDevices is called to refresh the cache? I think you need to refresh the cache on failure too, it's only done later in the series and it needs to be done earlier. This function you're commenting on (`hid_joystick_enum_device()`) is only called from `EnumDevices()`. I used to have refresh inside of that function in the original series, but it was moved to `dinput8_EnumDevices()` on your suggestion. We can move it back here if that's preferred.
I can unsplit things to have the cache refresh on failure to open the device, but that'd be done elsewhere. Even split, the behavior shouldn't be any worse than it already is without these patches. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10364#note_137332