June 16, 2026
4:50 p.m.
On Wed May 27 00:59:35 2026 +0000, Zhiyi Zhang wrote:
Yes, usually we separate the tests and the fix. Then, submit the tests first with a todo_wine. However, in this case, you can either introduce a todo_wine support in `check_sizes()` or merge the patches into one patch. Since the fix is small, adding todo_wine to `check_sizes()` seems unnecessary, and one patch is fine. Thank you for the explanation, it is very much appreciated. I think I have addressed all points brought up so far, including in the other review comment. Could you review the new diff at your convenience? Thanks!
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10809#note_143293