On Mon Apr 20 14:08:01 2026 +0000, Connor McAdams wrote:
changed this line in [version 5 of the diff](/wine/wine/-/merge_requests/10364/diffs?diff_id=261726&start_sha=9cef9159d5dad342cb04cc69bcf554ae48fc1ea5#4ad1ac26b8a52443a124ce8c55def4aa2a4f5075_162_138) I've reworked things in the current revision, removing `DevicePath` from the registry completely because I think it was just causing more confusion.
The way it is done now is: - All existing registry entries are read into a list. - Enumerated devices check this list to find an existing VID/PID/index, if one exists, it is reused. - If no VID/PID/index pairing exists, a new guidInstance is created, and added to a separate list. - After all devices have been assigned a guidInstance, we check if there are any entries in the new guidInstance list, and write them to the registry. I think this method is clearer, and I've also tried splitting it a bit to make review easier. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10364#note_137098