On Thu May 28 22:53:09 2026 +0000, Elizabeth Figura wrote:
Yes, I added a test in there, but it doesn't test the issue I'm fixing. The existing tests show it: `Stop()` is called on line 5106, but `GetCurrentPosition()` then returns 1234, after the previous `GetPositions()` call while it was running returned 1334. Results from the .avi file are different. That's GetCurrentPositions() while stopped, though. This is about GetCurrentPositions() while running, after stopping for a measurable amount of time. To put it another way, if I delete the lines which update `graph->stream_elapsed` and `graph->current_pos` in `Pause()`, none of the current tests fail. That's probably because you're not running the tests in interactive mode. Running the tests in interactive mode after deleting those lines, I see failures on lines 5096 and 5102, which is exactly the tests I'd expect to see fail. I rebased and added tests in `test_graph_seeking()`, but the todos there are not fixed by this MR. The stop time is zero after `Stop()` is called, so we would need to call `SetPositions()` to run it again, which wouldn't be useful AFAIK.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10885#note_141637