On Thu May 14 14:36:17 2026 +0000, Stian Low wrote:
These logs were kept for the patch until considered fully resolved: ``` 0190:fixme:d3d:wined3d_swapchain_init The application requested more than one back buffer, this is not properly supported. Please configure the application to use double buffering (1 back buffer) if possible. 0190:fixme:d3d:wined3d_swapchain_init Unimplemented swap effect 0x3. ``` This MS example has a comment referring to BufferCount = 2 as double buffering: https://learn.microsoft.com/en-us/windows/win32/api/dxgi/ne-dxgi-dxgi_swap_e... d3d9/tests/visual.c indeed fails with this patch. I will consider modding to only skip wined3d_swapchain_gl_rotate() for particular cases such as d3d11 flip swap_effect and leaving d3d9 in place.
I'm also reviewing d3d tests for correctness because despite d3d9/tests/visual.c failing, d3d9 games tested so far that use flip swap_effect work with the patch without any issues. However these d3d9 games do not render darker for vulkan even without the patch. List of d3d9 games using swap_effect to test: https://www.pcgamingwiki.com/wiki/Topic:Xqqq11z22nvv8vpk So far only "Hotline Miami 2: Wrong Number" has been tested which has these logs which confirms the flip effect and buffer_count > 1 FIXME condition: ``` 0024:fixme:d3d9:device_init present_parameters->BackBufferCount 4, SwapEffect 5 0024:fixme:d3d:wined3d_swapchain_init The application requested more than one back buffer, this is not properly supported. Please configure the application to use double buffering (1 back buffer) if possible. 0024:fixme:d3d:wined3d_swapchain_init Unimplemented swap effect 0x3. ``` D3DSWAPEFFECT_FLIPEX = 5 maps to WINED3D_SWAP_EFFECT_FLIP_SEQUENTIAL 0x3 via wined3dswapeffect_from_d3dswapeffect() for ./dlls/d3d9/device.c Desipte similar logs being spammed, vulkan is not rendered darker `0024:fixme:d3d:wined3d_swapchain_init Unimplemented swap effect 0x3.` Note "Hotline Miami 2: Wrong Number" requires latest vkd3d reported here: https://bugs.winehq.org/show_bug.cgi?id=50182#c3 gl renderer for "Hotline Miami 2: Wrong Number" seems to work for all cases. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10567#note_139900