Aug. 17, 2026
6:32 p.m.
I read over the patches. First of all a big thumbs up to Stian for sticking with this and following up on review. What looked originally like a one line bugfix turned into a complicated topic. I read through Henri's and Zeb's comments. If any of my comments conflict with theirs listen to them, not me :-) I saw a few opportunities for simplifying the code. Nothing major, I think the general structure of the patches is OK. I have pointed them out in the diffs itself Regarding delayed clears and swaps: The locations are already swapped by wined3d_swapchain_gl_rotate and wined3d_swapchain_vk_rotate. I think what is missing is rotating the clear color. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10567#note_149090