From: Nikolay Sivov <nsivov@codeweavers.com> Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com> --- dlls/msxml3/doctype.c | 4 ++-- dlls/msxml3/tests/domdoc.c | 14 ++++++++++++++ 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/dlls/msxml3/doctype.c b/dlls/msxml3/doctype.c index a0c94339237..3b8cd805aef 100644 --- a/dlls/msxml3/doctype.c +++ b/dlls/msxml3/doctype.c @@ -284,9 +284,9 @@ static HRESULT WINAPI domdoctype_cloneNode(IXMLDOMDocumentType *iface, VARIANT_B static HRESULT WINAPI domdoctype_get_nodeTypeString(IXMLDOMDocumentType *iface, BSTR *p) { - FIXME("%p, %p: stub\n", iface, p); + TRACE("%p, %p.\n", iface, p); - return E_NOTIMPL; + return return_bstr(L"documenttype", p); } static HRESULT WINAPI domdoctype_get_text(IXMLDOMDocumentType *iface, BSTR *p) diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c index bf32c5c88ac..4dc15f64674 100644 --- a/dlls/msxml3/tests/domdoc.c +++ b/dlls/msxml3/tests/domdoc.c @@ -10281,6 +10281,7 @@ static const get_node_typestring_t get_node_typestring[] = { static void test_get_nodeTypeString(void) { const get_node_typestring_t *entry = get_node_typestring; + IXMLDOMDocumentType *doctype; IXMLDOMDocument *doc; HRESULT hr; BSTR str; @@ -10315,6 +10316,19 @@ static void test_get_nodeTypeString(void) entry++; } + hr = IXMLDOMDocument_loadXML(doc, _bstr_(szEmailXML), NULL); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + + hr = IXMLDOMDocument_get_doctype(doc, &doctype); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + hr = IXMLDOMDocumentType_get_nodeTypeString(doctype, NULL); + ok(hr == E_INVALIDARG, "Unexpected hr %#lx.\n", hr); + hr = IXMLDOMDocumentType_get_nodeTypeString(doctype, &str); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + ok(!wcscmp(str, L"documenttype"), "Unexpected string %s.\n", debugstr_w(str)); + SysFreeString(str); + IXMLDOMDocumentType_Release(doctype); + IXMLDOMDocument_Release(doc); free_bstrs(); } -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/10664