Re: [PATCH v6 0/5] MR10779: winex11: Keyboard layouts rework, part 2

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/winex11.drv/keyboard.c:
> +    return strcmp( map_key->variant, entry->variant );
> +}
> +
> +static DWORD klid_from_xkb_layout( const char *layout, const char *variant )
> +{
> +    struct klid_map_entry key = { layout, variant };
> +    const struct klid_map_entry *entry;
> +
> +    if (!variant)
> +        return 0;
> +
> +    entry = bsearch( &key, klid_map, ARRAY_SIZE(klid_map), sizeof(*klid_map), klid_map_cmp );
> +    if (entry) return entry->klid;
> +
> +    FIXME( "Unknown variant %s\n", debugstr_a(variant) );
> +    return ~0u;
> In general I think -1 is less error prone, if type gets ever changed to a larger size ~0u might not be extended.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10779#note_140318