On Wed Apr 8 17:16:55 2026 +0000, Tim Clem wrote:
New stuff looks good to me, ~~but I do think you should use the constant APPLICATION_USER_MODEL_ID_MAX_LENGTH rather than a hardcoded 128. It's in appmodel.h~~ Scratch that, I see that that's not upstream. Perhaps worth adding defines for APPLICATION_USER_MODEL_ID_MAX_LENGTH and APPLICATION_USER_MODEL_ID_MIN_LENGTH to appmodel.h? Quick question on the Windows CI results:
Set(L"") and Set(129-char string) both returned S_OK on Win10 21H2 instead of E_INVALIDARG. Should I keep the validation or drop it to match native behavior? I also have a fix ready for the code quality issue (uninitialized \*appid when CoTaskMemAlloc fails). Will push it once I got info on the validation behavior. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10565#note_135524