```diff + /* Multisampling is allowed. */ + present_parameters.MultiSampleType = D3DMULTISAMPLE_2_SAMPLES; + hr = IDirect3D8_CreateDevice(d3d, D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL, window, + D3DCREATE_SOFTWARE_VERTEXPROCESSING, &present_parameters, &device); + ok(SUCCEEDED(hr), "Failed to create device, hr %#lx.\n", hr); ```
This will need to check for support for D3DMULTISAMPLE_2_SAMPLES first, similar to what e.g. test_swapchain_multisample_reset() does; currently the test is failing on the CI. Note that for the CI it may be better to use D3DMULTISAMPLE_4_SAMPLES instead of D3DMULTISAMPLE_2_SAMPLES here; IIRC llvmpipe supports 4xMSAA but not 2xMSAA. In principle that applies to the d3d9 test as well, although we're expecting things to fail there regardless. Since we're looking at the details at this point, I notice you're adding both ```diff ok(SUCCEEDED(hr), "Failed to create device, hr %#lx.\n", hr); ``` and ```diff ok(hr == D3D_OK, "Got hr %#lx.\n", hr); ``` style tests here. I think we've generally settled on preferring the latter style, but either way it would be good to pick one or the other. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10874#note_141520