On Wed Jun 10 18:20:49 2026 +0000, Etaash Mathamsetty wrote:
changed this line in [version 3 of the diff](/wine/wine/-/merge_requests/11103/diffs?diff_id=274138&start_sha=ac5e4f4af75031e888e446d54bd9511b9b21dc92#be6b1a6381414c8dae6f91e46942652a04a69f08_823_823) Well, I understand that most compositors *will* refuse to activate the window without the serial and that it will effectively make it work like FlashWindow is supposed to, but the protocol spec actually states:
Some compositors might refuse to activate toplevels when the token doesn't have a valid and recent enough event serial.
Which can also mean that some compositors *will* activate windows even without a serial. This would not be the correct behavior for FlashWindow, and I think it means we simply cannot implement FlashWindow that way. We should probably just focus on ActivateWindow, I don't think FlashWindow is used so much anyway. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/11103#note_142929