I understand that familiarity with Android is important here, but I would also really appreciate feedback on the changes themselves. The series is limited to wineandroid, but it still touches a lot of code there, and as I’m still new to the project, I’m not always confident about what is acceptable or what the preferred patterns are in Wine. Even high-level or structural feedback would be very helpful.
In general, although having the big picture and future plans available for reference, we prefer smaller MRs for actual review, so my first advice would be to keep this MR as draft then split this into smaller batches of ~5 patches or less. The smaller the number the easier it will be, assuming the changes are also fairly uncontroversial, to get reviewed and approved. This seems to be the case for the first few changes here at least, although again, I know nothing about Android. From a quick glance over the later changes, I don't see anything obvious either, they seem to be relatively small and well split and isolated from each other, but the larger design changes decisions will probably be up to @julliard to decide. More detailed discussion about later changes also feel a bit pointless, as they may end up changing over time, because of previous changes iterations or just because you might decide to change your mind. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10569#note_136459