Re: [PATCH v4 0/3] MR11001: ntdll, ntoskrnl.exe: account for read-only cookie in loader

[Alexandre Julliard (＠julliard)]

Alexandre Julliard (@julliard) commented about dlls/kernel32/tests/loader.c:
> +
> +    create_test_dll_sections(&dos_header, &nt_header, sections, section_data, dll_name);
> +
> +    SetLastError(0xdeadbeef);
> +    hlib = LoadLibraryA(dll_name);
> +    ok(hlib != NULL, "LoadLibrary failed err %lu\n", GetLastError());
> +    if (!hlib)
> +    {
> +        DeleteFileA(dll_name);
> +        return;
> +    }
> +
> +    if ((ULONG_PTR)hlib != nt_header.OptionalHeader.ImageBase)
> +    {
> +        skip("DLL was relocated (%p vs preferred %p); cannot verify cookie\n",
> +             hlib, (void *)(ULONG_PTR)nt_header.OptionalHeader.ImageBase);
> Why do you need to skip here?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/11001#note_142130