From: Francis De Brabandere <francisdb@gmail.com> Use %prec LOWER_THAN_ELSE on the empty EndIf_opt rule to explicitly resolve 4 dangling Else / End If shift/reduce conflicts. The remaining 6 conflicts are benign colon-chain ambiguities documented with %expect 6. --- dlls/vbscript/parser.y | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/dlls/vbscript/parser.y b/dlls/vbscript/parser.y index 9bbb02b5823..745068fa73e 100644 --- a/dlls/vbscript/parser.y +++ b/dlls/vbscript/parser.y @@ -94,6 +94,15 @@ static statement_t *link_statements(statement_t*,statement_t*); %define api.pure %start Program +/* Resolve dangling Else / End If conflicts via precedence: the empty + * EndIf_opt rule gets lower precedence than tELSE and tEND so that + * shift (binding to innermost If) always wins. The remaining 6 + * shift/reduce conflicts are benign colon-chain ambiguities where + * bison's default shift gives the correct greedy behavior. */ +%nonassoc LOWER_THAN_ELSE +%nonassoc tELSE tEND +%expect 6 + %union { const WCHAR *string; statement_t *statement; @@ -404,7 +413,7 @@ IfStatement | tIF Expression error { ctx->hres = MAKE_VBSERROR(VBSE_EXPECTED_THEN); YYABORT; } EndIf_opt - : /* empty */ + : /* empty */ %prec LOWER_THAN_ELSE | tEND tIF ElseIfs_opt -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/10343