On Mon Apr 20 16:16:54 2026 +0000, Elizabeth Figura wrote:
And tests for 1/7, 3/7, and 4/7? Rebased so each test sits next to its source commit. I also did a second review pass on the three new tests before pushing:
2/10 DIGCF_DEVICEINTERFACE filter: uses device ID 0005 to stay clear of other tests using 0000-0003, uppercase-strcmp for the instance ID comparison (matches existing convention in the file). 6/10 DEVPKEY_Device_Children: fetches the bus device via bus_class + DIGCF_DEVICEINTERFACE | DIGCF_PRESENT, matching the enumeration pattern used elsewhere in test_pnp_devices. 8/10 DEVPKEY_Device_Siblings: transient second child; counters and the DevQuery binary semaphores (device_added_sem / device_removed_sem) are drained on exit so the later WAIT_TIMEOUT assertions on those semaphores remain valid. Local setupapi_test devinst run: 4376 tests, 0 failures. ntoskrnl test compiles clean Sorry for the back-and-forth across multiple review rounds, hopefully this one is now fine. One question: I saw a merge attempt last Friday that did not go through because the branch was 49 (?) commits behind master. The series is now rebased onto wine 11.7. Does the merge pool automatically retry on the next merge window, or is there something I should do? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10604#note_137247