April 3, 2026
3:23 a.m.
On Fri Apr 3 03:23:02 2026 +0000, Brendan McGrath wrote:
Marking as draft whilst I investigate test failures. The test failures were a result of the `CoUninitialize` call. I thought the `CoInitialize` and `CoUninitialize` calls were ref counted and therefore `CoUninitialize` was a no-op if `CoInitialize` had been called elsewhere. I was wrong.
So I've removed the `CoUninitialize` call. I noticed that the `amstream` and `quartz filtergraph` tests fail on the `Implement IYUV_Open` commit, but pass again with the next commit. Should I squash these two commits (so the tests pass with all the individual commits)? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10549#note_134900